Fix RSOCtoPSD bridge for dimension 2 #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
I've hit this a few times, and always seen this choice as intentional. |
odow
reviewed
Dec 13, 2023
|
Yes I'm also hitting this often. When you have a code generating socs of various dimensions and one if them is t^2 >= x^2, it is bridged to RSOC and it tries to bridge from RSOC to PSD and you get this error. Anothet use case of this MultiSetMap is to have faster reformulations. For instance, in Sumofsquares, I reformulate 2x2 psd into socs instead of psd since it's faster |
odow
reviewed
Dec 13, 2023
odow
reviewed
Dec 13, 2023
|
Are you up late working on this? Otherwise I will push forward this afternoon |
odow
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this
MultiSetMapBridge, it should be easy to fix other similar case, e.g.,SecondOrderCone(1)->Nonnegatives(1)whileSecondOrderCone(2)->RotatedSecondOrderCone(2)but we can wait for someone or for a test (like in this case) requesting to fix these corner cases before doing it.