[Nonlinear] allow univariate operators with only gradient information #2542
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
commented
Sep 3, 2024
| try | ||
| _validate_register_assumptions(f′, op, 1) | ||
| f′′ = _checked_derivative(f′, op) | ||
| return _UnivariateOperator(f, f′, f′′) |
There was a problem hiding this comment.
I guess one open question is this behavior: do we always try to ForwardDiff f′ and fall back to not providing the Hessian if it fails?
|
I'll run https://github.com/jump-dev/MathOptInterface.jl/actions/runs/10764818835 to double check this is okay. |
|
D'oh. This will break a test in JuMP, because now univariate operators do not need Hessians. I should remove that test before we release this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2534