Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests from Gurobi #216 #763

Merged
merged 6 commits into from
Jun 14, 2019
Merged

Fix tests from Gurobi #216 #763

merged 6 commits into from
Jun 14, 2019

Conversation

odow
Copy link
Member

@odow odow commented Jun 10, 2019

These two changes were needed to get jump-dev/Gurobi.jl#216 passing.

The first is because Gurobi elects to run infeas_certificates=false, but still finds a partial certificate so ResultCount is 1.

The second is a bug. The variables need to be mapped to be valid.

@codecov-io
Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #763 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
+ Coverage   94.33%   94.35%   +0.01%     
==========================================
  Files          57       57              
  Lines        6226     6248      +22     
==========================================
+ Hits         5873     5895      +22     
  Misses        353      353
Impacted Files Coverage Δ
src/Test/UnitTests/basic_constraint_tests.jl 98% <ø> (ø) ⬆️
src/Test/contlinear.jl 100% <ø> (ø) ⬆️
src/Test/modellike.jl 99.05% <100%> (+0.02%) ⬆️
src/Bridges/Constraint/soc_to_psd.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057d027...b2c92de. Read the comment docs.

@blegat blegat added this to the v0.9 milestone Jun 10, 2019
@mlubin mlubin merged commit 52988f7 into master Jun 14, 2019
@odow odow deleted the od/fix_tests branch June 15, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants