Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dot_nonrecursive and add fused_map_reduce #87

Merged
merged 6 commits into from
May 6, 2021

Conversation

blegat
Copy link
Member

@blegat blegat commented Apr 10, 2021

JuliaLang/julia#36679 introduced a new function _dot_nonrecursive.
While this function does not exploit mutability, several methods redirect to it so implementing it allows to kill a few birds with one stone.
Our implementation of dot wasn't really correct since we didn't call dot recursively so this PR also fixes that.

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@cad04da). Click here to learn what that means.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #87   +/-   ##
=========================================
  Coverage          ?   84.82%           
=========================================
  Files             ?       18           
  Lines             ?     1535           
  Branches          ?        0           
=========================================
  Hits              ?     1302           
  Misses            ?      233           
  Partials          ?        0           
Impacted Files Coverage Δ
src/interface.jl 92.55% <63.63%> (ø)
src/MutableArithmetics.jl 96.66% <100.00%> (ø)
src/dispatch.jl 55.64% <100.00%> (ø)
src/linear_algebra.jl 96.42% <100.00%> (ø)
src/reduce.jl 100.00% <100.00%> (ø)
src/shortcuts.jl 69.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad04da...8d12514. Read the comment docs.

src/MutableArithmetics.jl Outdated Show resolved Hide resolved
src/dispatch.jl Show resolved Hide resolved
src/interface.jl Show resolved Hide resolved
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we try this with the DiffOpt example to see if it works?

@blegat
Copy link
Member Author

blegat commented May 6, 2021

No but it's exactly the use case we were discussing in #87 (comment)

@blegat blegat merged commit 5297338 into master May 6, 2021
@odow odow deleted the bl/dot_nonrecursive branch May 6, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants