-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethrow errors instead of returning FORCED_STOP #194
Conversation
Bump. Any thoughts on this? Here's another case where throwing an error would be helpful: https://discourse.julialang.org/t/nlopt-forced-stop-after-one-iteration-gradient-based-optimization/94383 |
Bump, can we get this please will be a big Quality of Life improvement! |
Thanks for working on this; it would be good to have. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
==========================================
+ Coverage 68.83% 69.07% +0.24%
==========================================
Files 2 2
Lines 799 802 +3
==========================================
+ Hits 550 554 +4
+ Misses 249 248 -1 ☔ View full report in Codecov by Sentry. |
How's this now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, for whatever that's worth 😄
I ran into this earlier today as well 😅 |
I'll merge once CI has passed. |
Closes #156
Closes #157
@ikirill I didn't want to push new commits to your
master
branch, so I've cherry-picked your commits over to this branch.