Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project.toml File #433

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Add Project.toml File #433

merged 3 commits into from
Feb 10, 2020

Conversation

ccoffrin
Copy link
Collaborator

@ccoffrin ccoffrin commented Feb 9, 2020

Updates for new package manager, tag bot, and drop support for julia v0.6.

@chriscoey
Copy link
Contributor

Thanks.
I feel like the author line can discourage contributors is generally unnecessary, so let's remove that.

@chriscoey chriscoey self-requested a review February 9, 2020 23:01
@ccoffrin ccoffrin requested a review from chriscoey February 10, 2020 00:52
@ccoffrin
Copy link
Collaborator Author

@chriscoey, CI is not passing but neither is master. This branch does appear to reproduce master.

I propose to merge this and then some maintenance needs to be done so that tests pass on master. Do you have some time to take a look? I tested in my computer locally and it seems that some of the tests take a very long time (100-500 seconds) in Julia v1.0; they ran faster in Julia v0.6.

@chriscoey
Copy link
Contributor

Thanks Carleton! I created #434 and I'll merge this now.

@chriscoey chriscoey merged commit 3337301 into master Feb 10, 2020
@chriscoey chriscoey deleted the project branch February 10, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants