num cuts as attribute #446
Conversation
|
not sure what happened with precompiling here |
| """ | ||
| struct NumberOfCuts <: MOI.AbstractOptimizerAttribute end | ||
|
|
||
| function MOI.get(opt::Optimizer, ::NumberOfCuts) |
There was a problem hiding this comment.
Implement is_set_by_optimize and attribute_value_type, you can take example on MOI.NodeCount for instance
There was a problem hiding this comment.
these two methods are not implemented for NodeCount here no?
There was a problem hiding this comment.
ah ok I saw what you meant, done
|
@chriscoey looks good here |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 90.39% 90.18% -0.21%
==========================================
Files 12 12
Lines 1020 1029 +9
==========================================
+ Hits 922 928 +6
- Misses 98 101 +3
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Thanks for adding this @matbesancon, looks good! |
|
I could have sworn I selected squash when I merged that, but doesn't look like it. Anyway, I invited you as a collaborator @matbesancon. If you want to tag a new minor version, go ahead! |
|
perfect thanks! |
No description provided.