Apply suggestions from code review

jump-dev · Mar 15, 2024 · f57eade · f57eade
1 parent 8af724e
commit f57eade
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/src/QCQP/MOI_wrapper.jl b/src/QCQP/MOI_wrapper.jl
@@ -232,7 +232,6 @@ function _subs_ensure_moi_order(p::PolyJuMP.ScalarPolynomialFunction, old, new)
     return PolyJuMP.ScalarPolynomialFunction(poly, moi_vars)
 end
 
-
 function _subs!(
     p::PolyJuMP.ScalarPolynomialFunction,
     index_to_var::Dict{K,V},

diff --git a/src/nl_to_polynomial.jl b/src/nl_to_polynomial.jl
@@ -115,7 +115,7 @@ end
 
 function _scalar_polynomial(d::Dict{K,V}, ::Type{T}, poly) where {T,K,V}
     var_set = Set(MP.variables(poly))
-    variable_map = Tuple{K, V}[(k, v) for (k, v) in d if v in var_set]
+    variable_map = Tuple{K,V}[(k, v) for (k, v) in d if v in var_set]
     sort!(variable_map, by = x -> x[2], rev = true)
     variables = [x[1] for x in variable_map]
     P = MP.polynomial_type(V, T)

diff --git a/test/qcqp_extra.jl b/test/qcqp_extra.jl
@@ -16,12 +16,11 @@ function test_unconstrained_before_projection(T)
         () -> PolyJuMP.QCQP.Optimizer{T}(optimizer),
     )
     PolyJuMP.@variable(model, -1 <= a[1:2] <= 1)
-    PolyJuMP.@objective(model, Min, a[1]^2*a[2]^2)
+    PolyJuMP.@objective(model, Min, a[1]^2 * a[2]^2)
     PolyJuMP.optimize!(model)
 
     vis = MOI.get(inner, MOI.ListOfVariableIndices())
     @test length(vis) == 4
-
     F = MOI.ScalarQuadraticFunction{T}
     S = MOI.EqualTo{T}
     cis = MOI.get(inner, MOI.ListOfConstraintIndices{F,S}())
@@ -35,12 +34,11 @@ function test_unconstrained_after_projection(T)
         () -> PolyJuMP.QCQP.Optimizer{T}(optimizer),
     )
     PolyJuMP.@variable(model, -1 <= a <= 1)
-    PolyJuMP.@objective(model, Min, a^2)    
+    PolyJuMP.@objective(model, Min, a^2)
     PolyJuMP.optimize!(model)
 
     vis = MOI.get(inner, MOI.ListOfVariableIndices())
     @test length(vis) == 1
-
     F = MOI.ScalarQuadraticFunction{T}
     S = MOI.EqualTo{T}
     cis = MOI.get(inner, MOI.ListOfConstraintIndices{F,S}())
@@ -60,7 +58,7 @@ function test_subs!_preserves_moi_sync(xs, ys, T)
 
     mask = rand(Bool, length(xs))
     is = Random.shuffle(eachindex(xs)[mask])
-    index = Dict{eltype(mois), eltype(xs)}(zip(mois[is], ys[is]))
+    index = Dict{eltype(mois),eltype(xs)}(zip(mois[is], ys[is]))
 
     moi_map = Dict(zip(xs, mois))
     moivars = [moi_map[v] for v in MP.variables(p)]
@@ -171,4 +169,4 @@ import TypedPolynomials
     types = [Float64, BigFloat, Rational{BigInt}]
     samples = 10
     TestQCQPExtra.run_tests_subs(z, w, samples, types)
-end
+end