Breaking changes for MOI v0.10

[metab0t]

• The new test/MathOptInterface/MOI_Wrapper.jl tests are all passed except some conflict tests that need further investigation
• The old test/MathOptInterface/MOI_Wrapper.jl is renamed as test/MOI_Wrapper_legacy.jl to wipe out old MOI.Test related tests and keep handwritten tests. test/MathOptInterface/MOI_Wrapper.jl tests are all passed.
• Some of test/MathOptInterface/MOI_callbacks.jl tests failed. @joaquimg Would you like to have a look?
• I tried to solve Xpress ignore LP warm starts #127 by using XPRSaddmipsol to set up initial value of variables but I am not sure about the correctness.

[odow]

You can remove the deprecated test file entirely.

It's okay to exclude the tests for now. They can be fixed in future PRs.

[joaquimg]

Please do:

I tried to solve Xpress ignore warm starts #127 by using XPRSaddmipsol to set up initial value of variables but I am not sure about the correctness.

in a separate PR.

[joaquimg]

@metab0t callbacks pass locally in master before you commits?

[metab0t]

Please do:

I tried to solve Xpress ignore warm starts #127 by using XPRSaddmipsol to set up initial value of variables but I am not sure about the correctness.

in a separate PR.

Done.

[metab0t]

@metab0t callbacks pass locally in master before you commits?

Yes, it passes before my commits.

[metab0t]

The callback error

[joaquimg]

a few tests disappeared, can you review that?

[joaquimg]

I noticed @odow asked for the removal of the old tests.
Are those corner cases covered in the default MOI tests?

[odow]

Ah sorry. To clarify: you can remove most of the deprecated test file, i.e., anything that called MOI.DeprecatedTest. If there were additional Xpress-specific tests, we should keep those.

[odow]

@metab0t this would be easier if I gave you access to make a PR to the jump-dev remote so that CI could run.

Are you based at a university? Your GitHub profile is a little sparse...

[odow]

@metab0t, I talked to @joaquimg and I've sent you an invite to be an outside collaborator. Use the access wisely :)

The easiest thing to do is start a new PR against the jump-dev remote (CI only runs if you have access to the secret to enable Xpress to download).

Let me know if you need help doing that.

[metab0t]

Ah sorry. To clarify: you can remove most of the deprecated test file, i.e., anything that called MOI.DeprecatedTest. If there were additional Xpress-specific tests, we should keep those.

OK, I will add those additional tests.

@metab0t, I talked to @joaquimg and I've sent you an invite to be an outside collaborator. Use the access wisely :)

The easiest thing to do is start a new PR against the jump-dev remote (CI only runs if you have access to the secret to enable Xpress to download).

Let me know if you need help doing that.

Thanks! I have accepted the invitation. I will start a new PR today.

@metab0t this would be easier if I gave you access to make a PR to the jump-dev remote so that CI could run.

Are you based at a university? Your GitHub profile is a little sparse...

Yes, I am currently a PhD student.

[metab0t]

New PR #146 is opened.