Refactor and simplify src/MOI/MOI_callbacks.jl #244
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 63.52% 63.73% +0.20%
==========================================
Files 6 6
Lines 3545 3513 -32
==========================================
- Hits 2252 2239 -13
+ Misses 1293 1274 -19 ☔ View full report in Codecov by Sentry. |
| # If we added a cut from the existing pool, it means that the current | ||
| # solution violates a cut that we previously added but that has since | ||
| # been deleted. |
There was a problem hiding this comment.
I think the pont is, there are at leas three thing that might happen when a cut is added in a callback
1 - only added to that node
2 - added to all nodes
3 - only added to a node and its child
Is it the difference between UserCuts and LazyCuts?
There was a problem hiding this comment.
at least from 2022, it seems that cuts will be applied to child:
XPRSaddcuts, XPRSaddcuts64
Purpose
Adds cuts directly to the matrix at the current node. Any cuts added to the matrix at the current node and
not deleted at the current node will be automatically added to the cut pool. The cuts added to the cut pool
will be automatically restored at descendant nodes.
There was a problem hiding this comment.
I guess I don't really see why we need this. If Xpress has removed a cut, then we will at some point visit a violated solution and add a new one. The MOI callbacks do not enforce that once a solution is cut it will never be revisited.
And yeah, the return isn't tested, so I don't think this is actually doing anything.
Closes #195