Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting Nothing for MOI.TimeLimitSec #262

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix setting Nothing for MOI.TimeLimitSec #262

merged 1 commit into from
Apr 3, 2024

Conversation

odow
Copy link
Member

@odow odow commented Apr 3, 2024

Fixes #255 (comment)

The test_attribute_TimeLimitSec test fails mid-test, leaving the optimizer with a time limit of 1.0 seconds.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.96%. Comparing base (96fd052) to head (fe2ecbd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   67.97%   67.96%   -0.02%     
==========================================
  Files           6        6              
  Lines        3307     3309       +2     
==========================================
+ Hits         2248     2249       +1     
- Misses       1059     1060       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit 4bc4462 into master Apr 3, 2024
16 checks passed
@odow odow deleted the od/timelimit branch April 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant