Deprecate whitelisted_params config #65
Conversation
This allows people to switch to the new config without breaking their applications or requiring a new release for libraries using this gem.
Even if compact, it has the same meaning.
kennyadsl
force-pushed
the
kennyadsl/deprecate-whitelisted_parameters
branch
from
fe7de6c to
4fb8c63
Compare
|
@jumph4x Why would you need to remove this in minor version? |
|
@panasyuk honest mistake (I understand you meant patch version), simply lapsed on the fact that this would be a breaking change in Spree and solidus. |
|
@kennyadsl thank you for this PR. Normally I would issue just another patch version bump. Should we bump patch or minor for this one? Because I made the mistake of cutting a patch version for the breaking change, it makes sense to make to patch this one as well, so that |
|
Agree, patch level seems the best release to me. Thanks! |
|
@jumph4x No, i meant exactly the change for "minor" version, which must not violate backward compatibility. Anyway, thank you for quick problem resolution. @kennyadsl, good job! |
|
@panasyuk I guess I do not fully understand you, because the removal happened in a patch version. Are we both talking about sem ver? EDIT: I think I understand. You meant in a sense of patch being a subset of minor and having even more constraints. Like I said previously, simply an oversight on my part. Thanks, all. |
This allows people to switch to the new config without breaking their applications or requiring a new release for libraries using this gem.
See solidusio/solidus#3865, which is still valid but merging this we allow people on older versions of Solidus to upgrade to newer versions of Rails.