Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: Fixed an issue where the right click paste was empty string #1575

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fixed: Fixed an issue where the right click paste was empty string #1575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ui/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,16 @@ declare module 'vue' {
Main: typeof import('./src/components/Kubernetes/MainContent/main.vue')['default']
MainContent: typeof import('./src/components/Kubernetes/MainContent/index.vue')['default']
NButton: typeof import('naive-ui')['NButton']
NButtonGroup: typeof import('naive-ui')['NButtonGroup']
NCard: typeof import('naive-ui')['NCard']
NCollapse: typeof import('naive-ui')['NCollapse']
NCollapseItem: typeof import('naive-ui')['NCollapseItem']
NConfigProvider: typeof import('naive-ui')['NConfigProvider']
NDataTable: typeof import('naive-ui')['NDataTable']
NDescriptions: typeof import('naive-ui')['NDescriptions']
NDescriptionsItem: typeof import('naive-ui')['NDescriptionsItem']
NDialogProvider: typeof import('naive-ui')['NDialogProvider']
NDivider: typeof import('naive-ui')['NDivider']
NDrawer: typeof import('naive-ui')['NDrawer']
NDrawerContent: typeof import('naive-ui')['NDrawerContent']
NDropdown: typeof import('naive-ui')['NDropdown']
Expand Down Expand Up @@ -51,6 +55,8 @@ declare module 'vue' {
NTree: typeof import('naive-ui')['NTree']
NUpload: typeof import('naive-ui')['NUpload']
NUploadDragger: typeof import('naive-ui')['NUploadDragger']
NUploadFileList: typeof import('naive-ui')['NUploadFileList']
NUploadTrigger: typeof import('naive-ui')['NUploadTrigger']
NWatermark: typeof import('naive-ui')['NWatermark']
RouterLink: typeof import('vue-router')['RouterLink']
RouterView: typeof import('vue-router')['RouterView']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be any issues with these lines of code. All the declared modules follow the recommended naming conventions, which should avoid conflicts in the project's external packages.

However, you may want to consider a few things:

  • Ensure that all imports (@@, declare, etc) are placed at the top of your file instead of right before the other files' declaration.
  • Use consistent indentation styles across the entire script for readability.
  • If not already done, consider renaming some symbols like Main and similar to something more unique if they appear frequently.

In general,

#!/usr/bin/python
#coding=utf-8
import numpy as np

def create_matrix(num_rows, num_cols):
    matrix = [[1 for _ in range(num_cols)] for _ in range(num_rows)]

will likely look cleaner than importing the same thing twice.

Also, make sure you have imported necessary libraries (e.g., numpy) first if needed.

If there’s anything specific that needs optimization or explanation about the code style or functionality, please provide further details so I can offer helpful insights!

Expand Down
18 changes: 9 additions & 9 deletions ui/src/hooks/useKubernetes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,18 +601,18 @@ export const initElEvent = (
text = await readText();
} catch (e) {
if (terminalStore.termSelectionText !== '') text = terminalStore.termSelectionText;
} finally {
socket.send(
JSON.stringify({
id: kubernetesStore.globalTerminalId,
k8s_id: terminalStore.currentTab,
type: 'TERMINAL_K8S_DATA',
data: text
})
);
}

e.preventDefault();

socket.send(
JSON.stringify({
id: kubernetesStore.globalTerminalId,
k8s_id: terminalStore.currentTab,
type: 'TERMINAL_K8S_DATA',
data: text
})
);
},
false
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not seem to contain any significant irregularities, potential issues, or optimizations at present. It appears well-written and ready for use.

Here is an update that could help improve readability:

export const initElEvent = async (text, textToRead) => { ...
}

const readTextFromLocal = () =>
  new Promise((resolve) => {
    // implementation goes here
  });

This way, both lines should be easier to understand, especially readTextFromLocal which can simplify future modifications more simply.

Let me know if you need further assistance, and please let me know if you have more questions about this or anything else related to programming.

Expand Down