perf: face mfa filter #1588
Merged
perf: face mfa filter #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fit2cloudrd
reviewed
Nov 20, 2024
| @@ -37,6 +37,7 @@ func (u *UserAuthClient) Authenticate(ctx context.Context) (user model.User, aut | |||
| return | |||
| } | |||
| unsupportedMfaTypes := map[string]bool{ | |||
| "face": true, | |||
| "FACE": true, | |||
| } | |||
| if resp.Err != "" { | |||
There was a problem hiding this comment.
To provide comprehensive recommendations:
Firstly, ensure the implementation matches the interface correctly; if unsupportedMfaTypes is intended to contain string boolean types, then use them properly. Secondly, consider using consistent indentation and spacing within the function blocks.
Potential issues or irregularities found:
- The docstring seems unnecessary since it's not related to the current functionality of the
Authenticatemethod which takes a channel argument instead of returning an error as shown in the original code snippet.
Optimization Suggestions:
None immediately evident from reviewing the sample provided.
For full review:
func (u *UserAuthClient) Authenticate(ctx context.Context, ch <-chan user.MFAInfoMessage) (user model.User, auto bool)
// ...
if resp.Err != "" {
panic(err.Error())
}
return u.user(), true // Assuming 'true' should match with the expected resultThis version fixes any apparent errors while suggesting better practices that could enhance readability and efficiency over the given code.
|
LeeEirc
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf: face mfa filter