Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify the platform protocol cursor disappears #4425

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: Modify the platform protocol cursor disappears #4425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/Form/FormFields/ProtocolSelector/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<template>
<div v-if="!loading" :class="showSetting ? 'show-setting' : 'hide-setting'">
<div :class="showSetting ? 'show-setting' : 'hide-setting'">
<div v-for="(item, index) in items" :key="item.name" class="protocol-item">
<el-input
v-model="item.port"
Expand Down Expand Up @@ -114,8 +114,7 @@ export default {
name: '',
items: [],
currentProtocol: {},
showDialog: false,
loading: false
showDialog: false
}
},
computed: {
Expand Down Expand Up @@ -144,10 +143,8 @@ export default {
watch: {
choices: {
handler(value, oldValue) {
this.loading = true
setTimeout(() => {
this.setDefaultItems(value)
this.loading = false
},)
},
deep: true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet for an options array has slightly different implementations compared to previous versions. It seems that in earlier iterations the this.defaultItems property was explicitly defined which is now omitted from this version of the same code.

This might have implications depending on whether you're looking at existing codebase's changes over time or if it's just a single update made recently (I would recommend checking the commit history or reviewing context notes when available).

If the removal makes sense within the current project's requirements while maintaining clarity and consistency, then there wouldn't be significant changes here. However, without more detailed information about what exactly should happen in both configurations I cannot make definitive recommendations regarding possible improvements or issues. If inconsistencies exist between these scenarios, they may need further investigation based on specific use case needs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no significant code difference found between these two snippets. Both appear to use Vue.js, but there may be minor syntax variations due to the context in which they were written (e.g. different versions of Vue).

However, if you have specific changes or optimizations requests related to JavaScript features like arrow functions and template components that would help improve performance or error handling, could you please specify them so I can assist more accurately?

Expand Down