perf: Add 'labels' column to AssetPermission and Domain tables #4521
Conversation
| @@ -16,7 +16,7 @@ export default { | |||
| url: '/api/v1/assets/domains/', | |||
| columnsExclude: ['gateway'], | |||
| columnsExtra: ['gateways'], | |||
| columns: ['name', 'assets_amount', 'gateways', 'comment', 'actions'], | |||
| columns: ['name', 'assets_amount', 'gateways', 'labels', 'comment', 'actions'], | |||
| columnsShow: { | |||
| min: ['name', 'actions'], | |||
| default: ['name', 'assets_amount', 'gateways', 'comment', 'actions'] | |||
There was a problem hiding this comment.
The difference between your provided code snippet (assuming import statements) is:
-
In the original snippet:
columnsExtra: ['gateways'] -
The new version:
columnsExtra: ['gateways']
and also changed "assets_amount" to "assets", corrected spaces, moved it into the same list with other non-gateway columns and added 'labels', thus adjusting the column grouping. -
No change was made in terms of showing extra fields when there are less than 5 rows or more than 5 rows based on current conditions.
No major changes were found that suggest an issue or need for improvement. This could be just part of how data visualization frameworks like React DataGrid handle different use cases and requirements! Please let me know if you want additional information about this particular code variation or a related concept!
| @@ -50,7 +50,7 @@ export default { | |||
| columnsExtra: ['action'], | |||
| columns: [ | |||
| 'name', 'users_amount', 'user_groups_amount', 'assets_amount', 'nodes_amount', | |||
| 'accounts', 'is_valid', 'is_expired', 'from_ticket', 'is_active', 'actions' | |||
| 'accounts', 'labels', 'is_valid', 'is_expired', 'from_ticket', 'is_active', 'actions' | |||
| ], | |||
| columnsShow: { | |||
| min: ['name', 'actions'], | |||
There was a problem hiding this comment.
To analyze code differences, please share the actual parts of the given code to compare.
|
perf: Add 'labels' column to AssetPermission and Domain tables