page-up/down: undo last up/down if items are skipped

Fix #4069
junegunn · Nov 9, 2024 · ca3f618 · ca3f618
1 parent 9c94f9c
commit ca3f618
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/terminal.go b/src/terminal.go
@@ -4468,13 +4468,16 @@ func (t *Terminal) Loop() error {
 					}
 				}
 
-				for ; linesToMove > 0; linesToMove-- {
-					cy := t.cy
+				for i := 0; i < linesToMove; i++ {
+					cy, offset := t.cy, t.offset
 					t.vset(cy + direction)
 					t.constrain()
-					if cy == t.cy ||
-						direction > 0 && t.offset >= maxOffset ||
-						direction < 0 && t.offset <= minOffset {
+					if cy == t.cy {
+						break
+					}
+					if i > 0 && (direction > 0 && t.offset > maxOffset ||
+						direction < 0 && t.offset < minOffset) {
+						t.cy, t.offset = cy, offset
 						break
 					}
 				}