-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect git managed tags #773
base: master
Are you sure you want to change the base?
Conversation
Add s:uniq() and use it
plug.vim
Outdated
@@ -600,13 +600,24 @@ function! s:update(force, names) | |||
call s:update_impl(1, a:force, a:names) | |||
endfunction | |||
|
|||
function! s:is_exec_helptags(docdir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function name is un-clear to be what should do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about s:is_need_exec_helptags
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm not native speaker, I cannot answer best. But has_helptags(x) or helptags_exists(x) ?
cc @junegunn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think do_need_exec_helptags()
is best.
I'll change it after I came back today or tomorrow. 😙
Thank you mattn 👍
Hi Junegunn,
Vim's documentation recommends that package include doc/tags.
:help package-create
:help help-writing
In fact, many packages does not contain doc/tags in the repository.
So I think that vim-plug is unconditionally running
:helptags
after installation and update.I think that should not run
:helptags
in the case of installation or update of that package.Please respect tags that git managed.
This PR is changed to execute
:helptags
only when either of the following conditions is satisfied.Please check it out.
Note:
Repository of package containing doc/tags (or doc/tags-??x)
--
Best regards,
Hirohito Higashi (h_east)