Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set default value for user agents #9

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

junghoon-vans
Copy link
Owner

@junghoon-vans junghoon-vans commented Jul 5, 2023

The User-Agent header is used to indicate the user agent that made the API call.
The guideline is to represent the official SDK in the following format.

User-Agent: Meilisearch <language> (<version>)

Therefore, the default User-Agent for our project is set as follows.

User-Agent: Meilisearch Java (v0.11.1); Spring Data Meilisearch (v1.0.0)

If you want to override the default, see namespace.xml in test resource.

<meilisearch:meilisearch-client id="meilisearchClient"
     client-agents="Meilisearch Java (v0.11.1), Spring Data Meilisearch (v1.0.0), Java (17)"/>

For example, if you wanted to specify Java, you could write something like this

@junghoon-vans junghoon-vans added the type: task A general task label Jul 5, 2023
@junghoon-vans junghoon-vans self-assigned this Jul 5, 2023
@junghoon-vans junghoon-vans changed the title chore: update user agents configuration chore: set default value for user agents Jul 5, 2023
@junghoon-vans junghoon-vans force-pushed the chore/update-user-agents-configuration branch from 51e18d6 to 1c5dd2a Compare July 5, 2023 09:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@junghoon-vans junghoon-vans merged commit 77f5129 into main Jul 5, 2023
@junghoon-vans junghoon-vans deleted the chore/update-user-agents-configuration branch July 5, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant