Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object authorization for union type #26

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

gabrielpra1
Copy link
Member

Closes #25

@gabrielpra1
Copy link
Member Author

Hey @moperacz, can you please check if this version now works for you?

In da2eba3 I also disabled the requirement for union types to define an authorize type, because we can just infer it from the underlying types. Does that make sense to you?

@gabrielpra1 gabrielpra1 force-pushed the fix-object-authoriation-union branch from da2eba3 to 013f665 Compare June 25, 2020 01:55
@moperacz
Copy link

yeah i will do this today TY!

@moperacz
Copy link

it is working perfectly now

@gabrielpra1 gabrielpra1 merged commit c89bab5 into master Jun 25, 2020
@gabrielpra1
Copy link
Member Author

gabrielpra1 commented Jun 25, 2020

Awesome! Version 1.0.1 with the fix is already available 😄

tcitworld added a commit to tcitworld/rajska that referenced this pull request Mar 24, 2023
Very similar to jungsoft#26, but for interfaces instead of unions

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit to tcitworld/rajska that referenced this pull request Mar 24, 2023
Very similar to jungsoft#26, but for interfaces instead of unions

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using object auth on union types is failing
2 participants