Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test lint workflow #10

Closed
wants to merge 3 commits into from
Closed

Test lint workflow #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e8e9d
Update App.tsx
junhao-ca Sep 14, 2024
93768d1
Update App.tsx
junhao-ca Sep 16, 2024
cfb2409
Merge branch 'junhaoliao:main' into main
junhao-ca Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions new-log-viewer/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,21 @@
import UrlContextProvider from "./contexts/UrlContextProvider";


// FIXME: this is a lint violation.

Check warning on line 6 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Unexpected 'fixme' comment: 'FIXME: this is a lint violation.'
// FIXME: this is another lint violation.

Check warning on line 7 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Unexpected 'fixme' comment: 'FIXME: this is another lint violation.'

/**
* Renders the main application.
*
* @return
*/
const App = () => {
return (
<UrlContextProvider>
return (<UrlContextProvider>

Check failure on line 15 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Parentheses around JSX should be on separate lines

Check failure on line 16 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Trailing spaces not allowed
<StateContextProvider>

Check failure on line 17 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected indentation of 8 spaces but found 12

Check failure on line 17 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected indentation of 8 space characters but found 12
<Layout/>

Check failure on line 18 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected indentation of 12 spaces but found 16
</StateContextProvider>

Check failure on line 19 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected indentation of 8 spaces but found 12
</UrlContextProvider>

Check failure on line 20 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected indentation of 4 spaces but found 8

Check failure on line 20 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected closing tag to match indentation of opening

Check failure on line 20 in new-log-viewer/src/App.tsx

View workflow job for this annotation

GitHub Actions / lint-check 

Expected indentation of 4 space characters but found 8
);
};

Expand Down
Loading