Skip to content

Commit

Permalink
Remove branch filter on PR triggers (#673 / #674)
Browse files Browse the repository at this point in the history
This commit removes the branch filtering on PRs. It prevented the
build pipeline from triggering in certain cases but we want to
trigger it for all PRs, so the filtering just did not make sense.

Closes: #673
PR: #674
  • Loading branch information
Michael1993 authored Sep 28, 2022
1 parent d9e926e commit f36ee4c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ on:
# We want to trigger our builds all the time for the default branch
# except when Shipkit creates a new version tag
push:
branches: 'main'
branches: ['main']
tags-ignore:
- 'v**'
# Each pull request is important to us, doesn't matter from which branch.
# Furthermore, we do not want to build on just the default GitHub Action
# events, we also want to react onto `labeled` events for our extended
# build execution
pull_request:
branches: '*'
types: [labeled, opened, synchronize, reopened]
# We also utilize this pipeline for releasing. By providing a `version`
# and setting `releasing` to `true`, we can trigger a release.
Expand Down

0 comments on commit f36ee4c

Please sign in to comment.