Fix handling of Windows junctions during temp dir cleanup

[marcphilipp]

Overview

Issue: #4299

---

I hereby agree to the terms of the JUnit Contributor License Agreement.

---

Definition of Done

• There are no TODOs left in the code
• Method preconditions are checked and documented in the method's Javadoc
• Coding conventions (e.g. for logging) have been followed
• Change is covered by automated tests including corner cases, errors, and exception handling
• Public API has Javadoc and @API annotations
• Change is documented in the User Guide and Release Notes

[marcphilipp]

Full stacktrace of the failing test on Windows:

org.junit.platform.commons.JUnitException: Failed to close extension context
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.io.IOException: Failed to delete temp directory C:\Users\RUNNER~1\AppData\Local\Temp\junit-2847030605030733067. The following paths could not be deleted (see suppressed exceptions for details): <root>
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.stream.SortedOps$RefSortingSink.end(SortedOps.java:395)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:261)
	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:261)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:510)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	... 3 more
	Suppressed: java.nio.file.DirectoryNotEmptyException: C:\Users\RUNNER~1\AppData\Local\Temp\junit-2847030605030733067
		at java.base/sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:270)
		at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
		at java.base/java.nio.file.Files.delete(Files.java:1153)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2816)
		at java.base/java.nio.file.Files.walkFileTree(Files.java:2870)
		... 14 more

[marcphilipp]

💬 This line fixes #4299

[quintesse]

It fixes the error, but it won't have deleted the junction, right?
Wouldn't it be possible to improve the implementation of fileOperations.delete() to not throw this error?

[marcphilipp]

It fixes the error, but it won't have deleted the junction, right?

It will be deleted by the call to resetPermissionsAndTryToDeleteAgain below.

Wouldn't it be possible to improve the implementation of fileOperations.delete() to not throw this error?

FileOperations exists only so that it can be replaced in tests.

[marcphilipp]

💬 This avoids following junctions and, potentially, deleting files outside of the temp dir. We need to delete them here because postVisitDirectory is not called after returning SKIP_SUBTREE.