Skip to content

Conversation

@marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jun 5, 2025

Overview

  • Use JDK 24 toolchain to run Gradle and Java-related tasks
  • Avoid ByteBuddy from trying to use Unsafe
  • Enable NullAway's JSpecify mode
  • Resolve nullability issues surfaced by NullAway's JSpecify mode

I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Copy link
Contributor

@vlsi vlsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to stop using sourceCompatibility/targetCompatibility properties

@sdeleuze
Copy link

sdeleuze commented Jun 5, 2025

Setting the "release" is indeed better, possible via Gradle JavaCompile options.

@marcphilipp marcphilipp changed the title Uss JDK 24 and enable NullAway's JSpecify mode Use JDK 24 and enable NullAway's JSpecify mode Jun 6, 2025
@marcphilipp
Copy link
Member Author

It would be great to stop using sourceCompatibility/targetCompatibility properties

Setting the "release" is indeed better, possible via Gradle JavaCompile options.

I've only used them for build logic projects, not production code. I'll change it to use --release instead.

@sormuras
Copy link
Member

sormuras commented Jun 6, 2025

I'll change it to use --release instead.

Didn't the Eclipse project export feature had issues with this? 🤔

@vlsi
Copy link
Contributor

vlsi commented Jun 6, 2025

@marcphilipp , @sdeleuze , @sormuras , it was a pleasure to listen to your talks and comments at IDEA Conf. Many thanks for pushing all this forward.

@marcphilipp
Copy link
Member Author

I'll change it to use --release instead.

Didn't the Eclipse project export feature had issues with this? 🤔

@sormuras Are you referring to the separate setting targeting Eclipse that @sbrannen added in ac0b9c1?

@ALUMINIS650
Copy link

Anffything basic i can help with?

@ALUMINIS650
Copy link

How do we enable the mode?

@marcphilipp marcphilipp force-pushed the marc/nullaway-on-jdk-24 branch from 76ef497 to 4391b43 Compare June 6, 2025 14:01
@marcphilipp marcphilipp force-pushed the marc/nullaway-on-jdk-24 branch from 4391b43 to 88bbc6f Compare June 6, 2025 14:11
@marcphilipp marcphilipp force-pushed the marc/nullaway-on-jdk-24 branch from 88bbc6f to 306ee4d Compare June 6, 2025 14:15
@marcphilipp marcphilipp marked this pull request as ready for review June 6, 2025 14:35
@marcphilipp marcphilipp force-pushed the marc/nullaway-on-jdk-24 branch 2 times, most recently from c012900 to 0e6ee91 Compare June 6, 2025 15:06
@marcphilipp marcphilipp force-pushed the marc/nullaway-on-jdk-24 branch from 0e6ee91 to d8364a9 Compare June 6, 2025 15:08
@marcphilipp marcphilipp merged commit d52ddac into main Jun 6, 2025
12 checks passed
@marcphilipp marcphilipp deleted the marc/nullaway-on-jdk-24 branch June 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants