Skip to content

Fail on classpath resource names that are blank after removing leading slash #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Jul 12, 2025

Fixes #4752.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp marcphilipp force-pushed the marc/4752-classpath-resource-name-validation branch from 3e6aa83 to e123ed6 Compare July 12, 2025 16:59
@marcphilipp marcphilipp changed the title Fail on classpath resource names that are blank after removing leading / Fail on classpath resource names that are blank after removing leading slash Jul 12, 2025
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work as expected.

I've made a suggestion for a DiscoverySelector.toSource() method, but that could be pushed to v6.

@marcphilipp marcphilipp force-pushed the marc/4752-classpath-resource-name-validation branch 2 times, most recently from b5f7605 to 4eb5925 Compare July 13, 2025 12:07
@marcphilipp marcphilipp force-pushed the marc/4752-classpath-resource-name-validation branch from 4eb5925 to 40812a2 Compare July 15, 2025 06:01
@marcphilipp marcphilipp merged commit 23405b8 into main Jul 16, 2025
14 checks passed
@marcphilipp marcphilipp deleted the marc/4752-classpath-resource-name-validation branch July 16, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClasspathResourceSelector is more lenient than ClasspathResourceSource
3 participants