-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #811 from stefanbirkner/maven-migration
Maven migration
- Loading branch information
Showing
19 changed files
with
3 additions
and
2,820 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
We love pull requests. Here is a quick guide: | ||
|
||
1. You need to have `ant` and a JDK (at least version 1.5) installed. | ||
1. You need to have Maven and a JDK (at least version 1.5) installed. | ||
2. Fork the repo. | ||
3. Ensure that you have a clean state by running `ant test`. | ||
3. Ensure that you have a clean state by running `mvn verify`. | ||
4. Add your change together with a test. (Tests are not needed for refactorings and documentation changes.) | ||
5. Format your code: Import the JUnit project in Eclipse and use its formatter or apply the rules in the `CODING_STYLE` file manually. | ||
6. Run `ant test` again and ensure all tests are passing. | ||
6. Run `mvn verify` again and ensure all tests are passing. | ||
7. Push to your fork and submit a pull request. | ||
|
||
Now you are waiting on us. We review your pull request and at least leave some comments. |
Oops, something went wrong.