Assumptions don't work in tests with expected exceptions

[petur]

The following test should be ignored, but fails with JUnit 4.8.2:

@Test(expected = UnsupportedOperationException.class)
public void testExpectedVsAssumption() {
    Assume.assumeTrue(false);
}

This test succeeds if run with @RunWith(JUnit4ClassRunner.class). The reason it works with the older runner, but fails with the new runner seems to be that org.junit.internal.runners.MethodRoadie.runTestMethod() has special handling for AssumptionViolatedException, but this handling is missing from org.junit.internal.runners.statements.ExpectException.evaluate().

[petur]

It would also be nice if ExpectException didn't wrap AssertionError. I would expect the following test to fail with an AssertionError, but it fails with an Exception instead:

@Test(expected = UnsupportedOperationException.class)
public void testExpectedVsAssertion() {
    Assert.assertTrue(false);
}

The stack trace is:

java.lang.Exception: Unexpected exception, expected<java.lang.UnsupportedOperationException> but was<java.lang.AssertionError>
at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:28)
at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
Caused by: java.lang.AssertionError:
at org.junit.Assert.fail(Assert.java:91)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertTrue(Assert.java:54)
at AssumptionVsExpectedTest.testExpectedVsAssertion(AssumptionVsExpectedTest.java:17)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:21)
... 15 more

[petur]

The same problem appears when using rules instead. This fails, but should probably succeed:

@Rule
public ExpectedException ex = ExpectedException.none();

@Test
public void testExpectedVsAssumption() {
    ex.expect(UnsupportedOperationException.class);

    Assume.assumeTrue(false);
}

In this case, it is easy to move the assumption above the expect, but that is not possible when using @test(expected = xxx.class).

[stefanbirkner]

The introductory issue is a duplicate of issue #98 and is already fixed in 4.9.

[stefanbirkner]

I fixed ExpectedException to work with assume and don't wrap AssertionErrors. AssertionErrors are still wrapped if you're using the expected=Foo.class notation. Please use ExpectedException to avoid wrapping.