No error/warning on non static method annotated with @DataPoint

[jschneider]

This test is marked as successfull but did not run:

 @RunWith( Theories.class )
 public class TheoriesTest {
  @Theory
  public void aTheory( String arg ) {
    System.out.println( "TheoriesTest.aTheory(" + arg + ")" );
    assertNotNull( arg );
  }

  @DataPoint
  public String getParam() {
    return "daParam";
  }
 }

I think the problem lies in Theories:126.
statement.evaluate() catches exceptions silently
(org.junit.experimental.theories.Theories.TheoryAnchor#methodCompletesWithParameters:158).

Therefore "handleDataPointSuccess" is called even when an exception has
been thrown....

So I think there are at least two things missing:

• Proper exception handling...
• Checking the DataPoint(s) methods for the static keyword

[MatrixFrog]

related: https://github.com/KentBeck/junit/issues/137

[MatrixFrog]

I have a test case and proposed fix at https://github.com/MatrixFrog/junit/tree/dataPoints -- I suppose I could throw a more JUnit-specific exception, rather than just RuntimeException, but I don't know what that would be.

[MatrixFrog]

Now packaged up as a shiny pull request: https://github.com/KentBeck/junit/pull/328

[marcphilipp]

Linking to #328.

[marcphilipp]

Closed #125 as it has been fixed by #623.