-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch release 4.13.1 seems to break maven surefire plugin #1678
Comments
Yes, I agree with that. @sormuras, do you have any further input? |
This was indeed fixed in junit-team/junit5#2198 for JUnit Vintage Engine 5.7. Can you upgrade to a 3.x version of Surefire? |
@marcphilipp I couldn't find any new version than 3.0.0-M5 though. |
Ah, sorry I overlooked that part in the issue description. Since 4.13.1 works fine in our sample project I suspect you may have mixed versions of JUnit artifacts on the classpath. Could you please provide a sample project that reproduces the issue? |
@marcphilipp I think that is possible I will try to reproduce it using a simple project. However the error says explicitly that it cannot parse |
@marcphilipp You are right about mixing JUnit 5 and JUnit 4. It seems that triggers maven-surefire-plugin to work in a very different way. https://github.com/junit-team/junit5-samples/pull/137/checks?check_run_id=1265044819 reproduced it. I'm thinking about possible solutions I can take:
|
Still I think this is somewhat annoying. A patch version bump requires quite some changes in the pom. |
Closing since upgrading to 5.7.0 of the JUnit Vintage Engine is a valid fix. Sorry for any inconvenience caused. |
See issue here: junit-team/junit4#1678
Not super sure of this but I can describe the issue.
After bumping up to 4.13.1. our CI reports failing to parse "4.13.1:
After looking into
JUnit4VersionCheck
, it seems it recently starts to support better versioning in this junit-team/junit5@f30c96a commit that went to junit-vintage-engine:5.7.0`.However the latest maven surefire plugins depends on
junit-platform-launcher:1.3.2
that eventually depends onjunit-vintage-engine:5.3.2
that doesn't support4.13.1
as versioning scheme.Forcing an upgrade:
breaks due to incompatible change over years:
Maybe this issue fits better into maven surefire plugin repo?
The text was updated successfully, but these errors were encountered: