AllMembersSupplier.addMultiPointMethods() swallows exceptions

[Stephan202]

From the class AllMembersSupplier:

private void addMultiPointMethods(List<PotentialAssignment> list) {
    for (FrameworkMethod dataPointsMethod : fClass.getAnnotatedMethods(DataPoints.class))
        try {
            addArrayValues(dataPointsMethod.getName(), list, dataPointsMethod.invokeExplosively(null));
        } catch (Throwable e) {
            // ignore and move on
        }
}

This try/catch block seems inappropriate to me: exceptions thrown in a @DataPoints-annotated method will silently be ignored. Surely this cannot be the desired behavior?

[marcphilipp]

Targetting this issue for 4.12 as GitHub does not allow adding labels to the corresponding pull request (#529).

[Stephan202]

@marcphilipp: Though I'd certainly would like to see this issue fixed, do note that the referenced pull request solves another problem. To my knowledge there has been no decision on how to handle exceptions originating from #addMultiPointArrayValues. Btw, I notice there's a similar suppression of Throwables in #addFields.

[marcphilipp]

@Stephan202 Thanks for the clarification.

[dsaff]

The exception-swallowing was indeed the initially intended behavior. I'm willing to accept that my original intentions may have been bad (http://www.quickmeme.com/meme/3q13l8/), but I think we're stuck with having to ask users to intentionally turn off the behavior that I originally intentionally turned on. :-(