Explicitly wrap float parameter for consistency #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcooney
approved these changes
Sep 5, 2020
marcphilipp
approved these changes
Sep 6, 2020
marcphilipp
changed the title
|
Thanks, @T45K! 👍 |
This was referenced Oct 12, 2020
This was referenced Mar 5, 2021
This was referenced Mar 18, 2021
Closed
Closed
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1141, while this param named actual was unwrapped, other params are still wrapped in Double or Float#valueOf.
I consider that its wrapping is necessary for consistency.