ExpectedException doesn't fail when an AssertionError is expected but not thrown #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tests expects code under test to throw an AssertionError by using ExpectedException (together with the #handleAssertionErrors option) but the code doesn't do so the test is not failing. This is because the ExpectedException rule catches its own AssertionError issued to signal that the expected exception is not thrown.
The attached commits fix this.