Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Travis CI (http://travis-ci.org). #776

Merged
merged 1 commit into from
Dec 14, 2013

Conversation

stefanbirkner
Copy link
Contributor

I like the Travis CI because it automatically runs ant test for each of my branches. Every developer can create a Travis account and enable this feature for its fork.

One nice feature is its support for Github's Commit Status API. Github's web interface shows us the CI result for each pull request.

Would be nice if we add support for Travis CI. It does not have to replace Cloudbee's Jenkins.

Any thoughts?

@kcooney
Copy link
Member

kcooney commented Nov 28, 2013

I thought we were migrating to maven (away from ant) for builds

@stefanbirkner
Copy link
Contributor Author

Do you know the current status of the Maven migration? I still use Ant for building JUnit.

@kcooney
Copy link
Member

kcooney commented Dec 3, 2013

Not sure

@dsaff Do we plan to continue to support both Ant and Maven for building JUnit?

@dsaff
Copy link
Member

dsaff commented Dec 4, 2013

I think that the plan is that maven becomes the build of record, with ant there for legacy. We should probably make a comment in the ant file to that effect.

@stefanbirkner
Copy link
Contributor Author

How about removing ant completely? No build.xml - no misunderstanding. And only one file to be maintained.

@askoog
Copy link

askoog commented Dec 5, 2013

+1 for only having one build system.

Currently, the https://github.com/junit-team/junit/blob/master/CONTRIBUTING.md file specifies that you should use ant to build, but the https://github.com/junit-team/junit/blob/master/BUILDING file says the project is built with maven...

@dsaff
Copy link
Member

dsaff commented Dec 5, 2013

I'm OK with deprecating ant.

Stefan, can you do the legwork of contacting the mailing list and finding out if anyone's still depending on the ant build?

@Tibor17
Copy link
Contributor

Tibor17 commented Dec 11, 2013

+1 to maintain Maven build system only

@dsaff
Copy link
Member

dsaff commented Dec 11, 2013

Keeping separate issues separate, can we use Travis CI with maven?

@stefanbirkner
Copy link
Contributor Author

Yes, it is the default. Should I squash the two commits?

@ansell
Copy link

ansell commented Dec 11, 2013

Travis CI works well with Maven. It also supports a recent build of oracle-jdk-8 (b117 I think), so you can test against that without installing it locally.

@@ -0,0 +1,5 @@
language: java
jdk:
- oraclejdk7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also add oraclejdk8 here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I can't by now because of issue #749.

@ansell
Copy link

ansell commented Dec 11, 2013

Reference documentation for Java builds on Travis CI is at:

http://about.travis-ci.org/docs/user/languages/java/

That specifies that Maven will be chosen (in automatic mode) over Ant if both are pom.xml and build.xml are found. If you did want to build with ant you would need to specify it in the .travis.yml file.

@dsaff
Copy link
Member

dsaff commented Dec 12, 2013

Stefan,

Sure, squash away! Thanks.

Simple CI for branches of JUnit forks. Now everybody can easily use CI for own branches. Pull requests are automatically build by the CI and the build result is visible on Github.
@stefanbirkner
Copy link
Contributor Author

Squashed.

dsaff pushed a commit that referenced this pull request Dec 14, 2013
@dsaff dsaff merged commit c6ab1af into junit-team:master Dec 14, 2013
@dsaff
Copy link
Member

dsaff commented Dec 14, 2013

Many thanks! Can you add to the release notes?

@stefanbirkner stefanbirkner deleted the travis branch December 15, 2013 23:37
@stefanbirkner
Copy link
Contributor Author

Done.

@jvz
Copy link

jvz commented Mar 31, 2014

Random note to add about the Maven-only build: you can use Maven to generate an Ant build anyways. There's no point in supporting Ant after you migrate to Maven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants