-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Travis CI (http://travis-ci.org). #776
Conversation
I thought we were migrating to maven (away from ant) for builds |
Do you know the current status of the Maven migration? I still use Ant for building JUnit. |
Not sure @dsaff Do we plan to continue to support both Ant and Maven for building JUnit? |
I think that the plan is that maven becomes the build of record, with ant there for legacy. We should probably make a comment in the ant file to that effect. |
How about removing ant completely? No build.xml - no misunderstanding. And only one file to be maintained. |
+1 for only having one build system. Currently, the https://github.com/junit-team/junit/blob/master/CONTRIBUTING.md file specifies that you should use ant to build, but the https://github.com/junit-team/junit/blob/master/BUILDING file says the project is built with maven... |
I'm OK with deprecating ant. Stefan, can you do the legwork of contacting the mailing list and finding out if anyone's still depending on the ant build? |
+1 to maintain Maven build system only |
Keeping separate issues separate, can we use Travis CI with maven? |
Yes, it is the default. Should I squash the two commits? |
Travis CI works well with Maven. It also supports a recent build of oracle-jdk-8 (b117 I think), so you can test against that without installing it locally. |
@@ -0,0 +1,5 @@ | |||
language: java | |||
jdk: | |||
- oraclejdk7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also add oraclejdk8 here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I can't by now because of issue #749.
Reference documentation for Java builds on Travis CI is at: http://about.travis-ci.org/docs/user/languages/java/ That specifies that Maven will be chosen (in automatic mode) over Ant if both are pom.xml and build.xml are found. If you did want to build with ant you would need to specify it in the .travis.yml file. |
Stefan, Sure, squash away! Thanks. |
Simple CI for branches of JUnit forks. Now everybody can easily use CI for own branches. Pull requests are automatically build by the CI and the build result is visible on Github.
Squashed. |
Add support for Travis CI (http://travis-ci.org).
Many thanks! Can you add to the release notes? |
Done. |
Random note to add about the Maven-only build: you can use Maven to generate an Ant build anyways. There's no point in supporting Ant after you migrate to Maven. |
I like the Travis CI because it automatically runs
ant test
for each of my branches. Every developer can create a Travis account and enable this feature for its fork.One nice feature is its support for Github's Commit Status API. Github's web interface shows us the CI result for each pull request.
Would be nice if we add support for Travis CI. It does not have to replace Cloudbee's Jenkins.
Any thoughts?