Upgrade to opentest4j 1.1.0

junit-team · Apr 29, 2018 · 12cda68 · 12cda68
1 parent a2c3558
commit 12cda68
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -26,7 +26,7 @@ junit4Version       = 4.12
 kotlinVersion       = 1.2.41
 log4jVersion        = 2.11.0
 mockitoVersion      = 2.18.3
-ota4jVersion        = 1.0.0
+ota4jVersion        = 1.1.0
 shadowVersion       = 2.0.4
 surefireVersion     = 2.21.0
 

diff --git a/junit-jupiter-engine/src/test/java/org/junit/jupiter/api/AssertionTestUtils.java b/junit-jupiter-engine/src/test/java/org/junit/jupiter/api/AssertionTestUtils.java
@@ -28,9 +28,9 @@ static void expectAssertionFailedError() {
 		throw new AssertionError("Should have thrown an " + AssertionFailedError.class.getName());
 	}
 
-	static void assertEmptyMessage(Throwable ex) throws AssertionError {
-		if (!ex.getMessage().isEmpty()) {
-			throw new AssertionError("Exception message should be an empty String, but was [" + ex.getMessage() + "].");
+	static void assertNullMessage(Throwable ex) throws AssertionError {
+		if (ex.getMessage() != null) {
+			throw new AssertionError("Exception message should be null, but was [" + ex.getMessage() + "].");
 		}
 	}
 

diff --git a/junit-jupiter-engine/src/test/java/org/junit/jupiter/api/FailAssertionsTests.java b/junit-jupiter-engine/src/test/java/org/junit/jupiter/api/FailAssertionsTests.java
@@ -10,9 +10,9 @@
 
 package org.junit.jupiter.api;
 
-import static org.junit.jupiter.api.AssertionTestUtils.assertEmptyMessage;
 import static org.junit.jupiter.api.AssertionTestUtils.assertMessageContains;
 import static org.junit.jupiter.api.AssertionTestUtils.assertMessageEquals;
+import static org.junit.jupiter.api.AssertionTestUtils.assertNullMessage;
 import static org.junit.jupiter.api.AssertionTestUtils.expectAssertionFailedError;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.fail;
@@ -36,7 +36,7 @@ void failWithoutArgument() {
 			expectAssertionFailedError();
 		}
 		catch (AssertionFailedError ex) {
-			assertEmptyMessage(ex);
+			assertNullMessage(ex);
 		}
 	}
 
@@ -69,7 +69,7 @@ void failWithNullString() {
 			expectAssertionFailedError();
 		}
 		catch (AssertionFailedError ex) {
-			assertMessageEquals(ex, "");
+			assertNullMessage(ex);
 		}
 	}
 
@@ -80,7 +80,7 @@ void failWithNullMessageSupplier() {
 			expectAssertionFailedError();
 		}
 		catch (AssertionFailedError ex) {
-			assertMessageEquals(ex, "");
+			assertNullMessage(ex);
 		}
 	}
 
@@ -104,7 +104,7 @@ void failWithThrowable() {
 			expectAssertionFailedError();
 		}
 		catch (AssertionFailedError ex) {
-			assertMessageEquals(ex, "");
+			assertNullMessage(ex);
 			Throwable cause = ex.getCause();
 			assertMessageContains(cause, "cause");
 		}
@@ -131,7 +131,7 @@ void failWithNullStringAndThrowable() {
 			expectAssertionFailedError();
 		}
 		catch (AssertionFailedError ex) {
-			assertMessageEquals(ex, "");
+			assertNullMessage(ex);
 			Throwable cause = ex.getCause();
 			assertMessageContains(cause, "cause");
 		}

diff --git a/junit-jupiter-engine/src/test/kotlin/org/junit/jupiter/api/KotlinFailAssertionsTests.kt b/junit-jupiter-engine/src/test/kotlin/org/junit/jupiter/api/KotlinFailAssertionsTests.kt
@@ -12,6 +12,7 @@ package org.junit.jupiter.api
 import org.junit.jupiter.api.AssertEquals.assertEquals
 import org.junit.jupiter.api.AssertionTestUtils.assertMessageContains
 import org.junit.jupiter.api.AssertionTestUtils.assertMessageEquals
+import org.junit.jupiter.api.AssertionTestUtils.assertNullMessage
 import org.opentest4j.AssertionFailedError
 import java.util.stream.Stream
 
@@ -40,15 +41,15 @@ class KotlinFailAssertionsTests {
         val ex = assertThrows<AssertionFailedError> {
             fail(null as String?)
         }
-        assertMessageEquals(ex, "")
+        assertNullMessage(ex)
     }
 
     @Test
     fun `fail with null message supplier`() {
         val ex = assertThrows<AssertionFailedError> {
             fail(null as (() -> String)?)
         }
-        assertMessageEquals(ex, "")
+        assertNullMessage(ex)
     }
 
     @Test
@@ -69,7 +70,7 @@ class KotlinFailAssertionsTests {
         val ex = assertThrows<AssertionFailedError> {
             fail(Throwable(throwableCause))
         }
-        assertMessageEquals(ex, "")
+        assertNullMessage(ex)
         val cause = ex.cause
         assertMessageContains(cause, throwableCause)
     }
@@ -92,7 +93,7 @@ class KotlinFailAssertionsTests {
         val ex = assertThrows<AssertionFailedError> {
             fail(null, Throwable(throwableCause))
         }
-        assertMessageEquals(ex, "")
+        assertNullMessage(ex)
         val cause = ex.cause
         assertMessageContains(cause, throwableCause)
     }