Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ExtensionPoint, ExtensionRegistrar, Position etc. and simplify implementation of JUnit 5 TestEngine #232

Closed
marcphilipp opened this issue Apr 29, 2016 · 4 comments
Closed

Remove ExtensionPoint, ExtensionRegistrar, Position etc. and simplify implementation of JUnit 5 TestEngine #232

marcphilipp opened this issue Apr 29, 2016 · 4 comments
Assignees
@sbrannen
Labels
theme: execution theme: extensions
Milestone
5.0 M1

Comments

@marcphilipp
Copy link
Member

No description provided.

@marcphilipp marcphilipp added this to the 5.0 M1 milestone Apr 29, 2016
@sbrannen
Copy link
Member

in progress

sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Rename ExceptionHandlerExtensionPoint to ExceptionHandler
23c20e5 
Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Rename test lifecycle callback extension APIs
9027966 
Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Introduce before & after test method callback APIs
7d84c39 
Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Simplify extension streaming and invocation algorithms
b681457 
Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Remove ExtensionPoint API in favor of Extension
368d6ae 
Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Remove ExtensionPointRegistry and ExtensionRegistrar
883ee95 
Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Do not mix execution of extensions and user code
b2ba6b9 
This commit separates the execution of extensions and user code with
regard to test lifecycle callbacks.

Issue: junit-team#232
@sbrannen
Copy link
Member

sbrannen commented May 2, 2016

The work in progress can be viewed here: https://github.com/sbrannen/junit5/commits/issue232-simplified-extension-model

And an official PR is forthcoming.

sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Do not synthesize @BeforeAll & @afterall methods as extensions
b691e6a 
This commit avoids unnecessary streaming and synthesizing of extensions
as lambda expressions for @BeforeAll and @afterall methods. Instead,
@BeforeAll and @afterall methods are now invoked directly using
standard for-loops.

Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Eagerly load and validate @beforeeach & @AfterEach methods
6b575f2 
With this commit @beforeeach and @AfterEach methods are looked up and
validated eagerly during the discovery phase instead of late in the game
during the execution phase.

This commit also extracts a new LifecycleMethodUtils class from the
ClassTestDescriptor.

Issue: junit-team#232
sbrannen added a commit to sbrannen/junit5 that referenced this issue May 2, 2016
@sbrannen
Delete discussion of programmatic extension registration in User Guide
aa32c53 
Issue: junit-team#232
@sbrannen sbrannen mentioned this issue May 3, 2016
Merged
@sbrannen
Copy link
Member

sbrannen commented May 3, 2016

See PR #237

sbrannen added a commit to sbrannen/junit5 that referenced this issue May 6, 2016
@sbrannen
Update User Guide regarding renamed and new extensions
744eb9b 
Issue: junit-team#232
@sbrannen
Copy link
Member

sbrannen commented May 6, 2016

Merged into master in 434a360.

@sbrannen sbrannen closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
theme: execution theme: extensions
Projects
None yet
Milestone
5.0 M1
Development

No branches or pull requests
2 participants
@sbrannen @marcphilipp