Treat text blocks as files in @CsvSource
#2734
Assignees
Milestone
Comments
sbrannen
changed the title
@CsvSource@CsvSource
3 tasks
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 1, 2021
|
Current work on this issue can be viewed in the following feature branch: main...sbrannen:issues/2734-treat-text-blocks-as-files-in-CsvSource |
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 3, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 3, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 3, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 3, 2021
7 tasks
|
FYI: PR #2737 is ready for technical review. |
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 4, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 4, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 4, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 4, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 6, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 6, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 25, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 25, 2021
sbrannen
added a commit
to sbrannen/junit5
that referenced
this issue
Oct 25, 2021
sbrannen
added a commit
that referenced
this issue
Oct 26, 2021
PR #2721 introduced experimental support for text blocks in @CsvSource; however, there was room for improvement. Prior to this commit, a CSV record within a text block could not contain a new line (\n), even if it was within a quoted string; whereas, this is supported when using @CsvSource's value attribute. In addition, comments do not make sense in a single string supplied via @CsvSource's value attribute, but they do make sense within a text block. This commit refines the text block support in @CsvSource by treating text blocks as complete CSV files, including support for comments beginning with a `#` symbol as well as support for new lines within quoted strings. Closes #2734
runningcode
pushed a commit
to runningcode/junit5
that referenced
this issue
Feb 15, 2023
PR junit-team#2721 introduced experimental support for text blocks in @CsvSource; however, there was room for improvement. Prior to this commit, a CSV record within a text block could not contain a new line (\n), even if it was within a quoted string; whereas, this is supported when using @CsvSource's value attribute. In addition, comments do not make sense in a single string supplied via @CsvSource's value attribute, but they do make sense within a text block. This commit refines the text block support in @CsvSource by treating text blocks as complete CSV files, including support for comments beginning with a `#` symbol as well as support for new lines within quoted strings. Closes junit-team#2734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
PR #2721 introduced experimental support for text blocks in
@CsvSource; however, there is room for improvement.A CSV line within a text block cannot currently contain a new line (
\n), even if it is within a quoted string; whereas, this is supported when using@CsvSource(value = ...).Comments do not make sense in a single string in
@CsvSource(value = ...), but they do make sense within@CsvSource(textBlock = ...).Related Issues
@CsvSource#2721@CsvSourceand@CsvFileSourceconfigurable #2735Deliverables
\nwithin quoted strings in text blocks.#in text blocks.String#stripIndent()is only available on JDK 15+.The text was updated successfully, but these errors were encountered: