Possibility to customize element resolving

[aaschmid]

Hi @sbrannen,

according to your last comment on TNG/junit-dataprovider#75, I looked deeper into the Extension API. I agree that I do not want to provide a custom test engine. Maybe you can help me about implementing an extension for junit-dataprovider to run the tests with junit-jupiter rather than a complete test engine.

Correct me if I am wrong but as far as I understand the Extension API is currently not capable of registering additional test cases. However, extending the junit-jupiter framework to be able to register another ElementResolver could discover additional (dynamic) test cases which fit the junit-dataprovider programming model.

I found no issue / feature request concerning this topic, so I opend this one. Have you already thought about the possibility of register custom ElementResolver or does that fit into your vision of junit5? I would love to help out providing a pull request if you give me a little vision how you could think about a good solution for it.
At my first tries it felt natural to use the Extension API for this but while doing so, I saw that it is only available / used within org.junit.platform.engine.TestEngine.execute(ExecutionRequest).

Cheers,
Andreas

[aaschmid]

As I haven't got an answer, I assume you either did not consider it yet as important enough or you have no clue how to do it (as I do / did).

Therefore I looked deeper into the code, played around a bit and got the following ideas how this could be solved (only ideas in arbitrary order):

• change / override the org.junit.jupiter.engine.discovery.TestMethodResolver via extension
• add some extension mechanism to org.junit.jupiter.engine.discovery.TestMethodResolver.resolveMethod(Method, ClassTestDescriptor, UniqueId)
  • could maybe also used for @TestFactory annotated test methods to include dynamic tests into the lifecyle and get @BeforeEach / @AfterEachsupport
• make it possible to register a new element resolver in org.junit.jupiter.engine.discovery.JavaElementsResolver

Please let me now if you like any of the ideas (or if you dislike this issue at all). I would love to get feedback to start with a simple implementation to get a proof-of-concept and to be able to further discuss possibilities.

Thanks & regards,
Andreas

[sbrannen]

@aaschmid, I apologize for the belated reply.

For personal reasons, I currently have practically zero time to devote to JUnit for the moment.

So, perhaps another member of the @junit-team/junit-lambda team can assist you.

Regards,

Sam

[aaschmid]

Hi @sbrannen, thanks for your response as I really appreciate it. It is much better to get a response saying that there is no time currently, compared to getting non at all. Last can be really frustrating.

All other help is also appreciated. Please note that I already created a draft for "make it possible to register a new element resolver in org.junit.jupiter.engine.discovery.JavaElementsResolver", as you can see by the activities above (#566). I like that idea and just gave it a shot :-)

Any feedback welcome :-)

[aaschmid]

If I understand #506 correctly, it could be an alternative of solving this. Namely, by replacing some the element resolver with a custom one.

[aaschmid]

Seems that @TestTemplate (#14) is an alternative solution for this ...

[nipafx]

@aaschmid It would be interesting to give it a try and report back whether the API is powerful enough.

[aaschmid]

Of course, first PoC is promising :-)

[aaschmid]

@TestTemplate (#14) is an alternative solution, closing issue