Bump Gradle to version 4.1 #1012
Conversation
|
|
||
| task wrapper(type: Wrapper) { |
There was a problem hiding this comment.
You really should only have this task on the root project. You don't need it on all of the subprojects.
build.gradle
Outdated
| task wrapper(type: Wrapper) { | ||
| description = 'Generates gradlew and gradlew.bat scripts' | ||
| gradleVersion = '4.1' | ||
| distributionType = Wrapper.DistributionType.ALL |
There was a problem hiding this comment.
Nice to have when writing/updating build logic.
There was a problem hiding this comment.
It was changed from "all" to "bin" some days ago via 719127f#diff-fd9d61e37d939c941e7a62077f38d62d -- please revert it as well.
There was a problem hiding this comment.
I prefer the bin distribution because it is smaller: 64M vs. 86M.
There was a problem hiding this comment.
Sure, I can change it back. I personally work in gradle builds a lot at work and always finding the docs really helpful.
I'll explicitly set the distribution type to BIN with a mention of this comment chain.
JLLeitschuh
force-pushed
the
task/gradle_4.1
branch
from
f4bef4d
to
60a201c
Compare
| /* | ||
| * Reasoning for using BIN: | ||
| * https://github.com/junit-team/junit5/pull/1012#discussion_r132061924 | ||
| */ |
There was a problem hiding this comment.
Commenting formatting seems weird but this is what spotless wants. so...
|
I'm hoping that this unblocks #1001 |
|
This has been merged into Thanks |
Overview
https://docs.gradle.org/4.1/release-notes.html
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations