Supply invocation index for @ParameterizedTest to test author #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you @jminkhar for opening this PR and for participating in the HackCommitPush event! 👍
I left a few comments and suggestions, if you can take a look :)
documentation/src/docs/asciidoc/release-notes/release-notes-5.10.0-M1.adoc
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/aggregator/ArgumentsAccessor.java
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedTestExtension.java
Outdated
Show resolved
Hide resolved
...ter-params/src/test/java/org/junit/jupiter/params/aggregator/AggregatorIntegrationTests.java
Show resolved
Hide resolved
…10.0-M1.adoc Co-authored-by: Juliette de Rancourt <derancourt.juliette@gmail.com>
…gregator/ArgumentsAccessor.java Co-authored-by: Juliette de Rancourt <derancourt.juliette@gmail.com>
… int instead of Integer
jminkhar
force-pushed
the
1668_index_invocation
branch
from
ef86944
to
e232d6c
Compare
juliette-derancourt
added a commit
that referenced
this pull request
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding the possibility to get the invocation index of any ArgumentsAccessor
Fixes #1668
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations