Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make String to Boolean parameter conversion more strict #3178

Merged
merged 6 commits into from
Apr 28, 2023
Merged

Make String to Boolean parameter conversion more strict #3178

merged 6 commits into from
Apr 28, 2023

Commits on Feb 27, 2023

  1. Force using 'true' or 'false' for boolean args 

    Cause use of anything other than 'true' or 'false' (case-insensitive)
fail in conversion, to make potential typos explicitly visible (instead
of implicitly just treating all else as 'false')

Includes a few tests for failures on invalid values, for conversions
handled by StringToBooleanAndCharPrimitiveConverter.

Issue: #3177
    @s-rwe
    s-rwe committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    e560035 View commit details
    Browse the repository at this point in the history

  2. Apply requested changes from CR (#3178) 

    Issue: #3177
    @s-rwe
    s-rwe committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ac8846e View commit details
    Browse the repository at this point in the history

  3. Apply more requested changes from CR (#3178) 

    Issue: #3177
    @s-rwe
    s-rwe committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    4217689 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Add release note entry and a note to user guide (#3178) 

    Issue: #3177
    @s-rwe
    s-rwe committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    2cc8f1a View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Move to breaking changes

    @marcphilipp
    marcphilipp authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    227829e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into issues/3177

    @marcphilipp
    marcphilipp authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    d0a2cf9 View commit details
    Browse the repository at this point in the history