-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document @MethodSource
as use case for @TestInstance
per-class lifecycle
#3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add another use case for TestInstace.PER_CLASS in Kotlin, namely, using regular simple class methods as the argument producer for @MethodSource (which is used for parameterized tests)
sbrannen
requested changes
Apr 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the User Guide in a similar fashion.
For tests authored using Kotlin programming language
sbrannen
changed the title
Update @TestInstance javadoc with a new use case
Document Apr 2, 2023
@MethodSource
as use case for @TestInstance
per-class lifecycle
sbrannen
approved these changes
Apr 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the user guide as well.
This has been merged into Thanks |
Thanks for merging. |
yhkuo41
pushed a commit
to yhkuo41/junit5
that referenced
this pull request
Apr 19, 2023
…fecycle This commit documents another use case for TestInstace.PER_CLASS in Kotlin, namely, using a regular simple class method as a factory method for @MethodSource (which is used for parameterized tests). Closes: junit-team#3219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Stack Overflow post: What use is @TestInstance annotation in JUnit 5?
Add another use case for
TestInstace.PER_CLASS
in Kotlin, which is, using regular simple class methods as the method factory for@MethodSource
(which is used for parameterized tests):I hereby agree to the terms of the JUnit Contributor License Agreement.