Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 3353 GitHub issue #3374

Closed
wants to merge 1 commit into from
Closed

Conversation

mipo256
Copy link

@mipo256 mipo256 commented Jun 29, 2023

Implmented #3353 feature

@marcphilipp
Copy link
Member

Thanks for your PR! I didn't see it at the time. In the meantime, this has been addressed in #3492.

@mipo256
Copy link
Author

mipo256 commented Oct 16, 2024

No problem, but I won't contribute in the future then, it is a bad UX IMHO. It is not a problem to select one implementation over the other. The problem is leaving the pr that came first without any feedback and then proceed with another that came after.

@marcphilipp
Copy link
Member

@mipo256 I totally understand your frustration. I assure you we didn't do that on purpose. As you're probably aware, this an independent project maintained mostly by people in their free time. That being said, getting swamped with notifications is a common occurrence.

In the future, also on other projects, linking your PR to the issue using GitHub's keywords makes it more visible and certainly would have increased the chance of us spotting the duplicate.

@mipo256
Copy link
Author

mipo256 commented Oct 16, 2024

I understand that this was unintentional, no problem :)
I'll try to do better next time, thanks for clarification, @marcphilipp! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants