Add Locale conversion format configuration property
#3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scordio
commented
Jul 31, 2023
| * | ||
| * @since 5.11 | ||
| */ | ||
| @API(status = INTERNAL, since = "5.11") |
There was a problem hiding this comment.
Is it correct to mark this as an internal API as the users are supposed to set these values in the config property only and not rely on the enum?
scordio
force-pushed
the
locale_conversion_config_property
branch
from
abfc72b to
95da5f8
Compare
scordio
changed the title
Locale conversion format configuration property
scordio
force-pushed
the
locale_conversion_config_property
branch
from
95da5f8 to
f833690
Compare
|
Waiting for #3507 to be finalized before moving forward. |
|
@scordio Are you still interested in continuing with this PR? |
|
Yes! This has fallen under my radar... thanks for the reminder 🙂 I'll rebase it and catch up with the missing parts in the upcoming weeks. |
scordio
force-pushed
the
locale_conversion_config_property
branch
from
f833690 to
85434d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3141.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations