Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Picocli's usage help auto width computation #3423

Merged
merged 6 commits into from
Aug 28, 2023

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Aug 11, 2023

Overview

Fixes #3419 by disabling Picocli's usage help auto width computation and tweaking tests.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@sormuras
Copy link
Member Author

No more stty: /dev/tty: No such device or address, but still a NullPointerException:

    java.lang.NullPointerException: Cannot invoke "org.junit.platform.console.tasks.ConsoleTestExecutor.discover(java.io.PrintWriter)" because the return value of "org.junit.platform.console.tasks.ConsoleTestExecutor$Factory.create(org.junit.platform.console.options.TestDiscoveryOptions, org.junit.platform.console.options.TestConsoleOutputOptions)" is null
    	at org.junit.platform.console.options.DiscoverTestsCommand.execute(DiscoverTestsCommand.java:43)
    	at org.junit.platform.console.options.DiscoverTestsCommand.execute(DiscoverTestsCommand.java:20)
    	at org.junit.platform.console.options.BaseCommand.call(BaseCommand.java:74)
    	at org.junit.platform.console.shadow.picocli.CommandLine.executeUserObject(CommandLine.java:2041)
    	at org.junit.platform.console.shadow.picocli.CommandLine.access$1500(CommandLine.java:148)
    	at org.junit.platform.console.shadow.picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
    	at org.junit.platform.console.shadow.picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
    	at org.junit.platform.console.shadow.picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
    	at org.junit.platform.console.shadow.picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
    	at org.junit.platform.console.shadow.picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
    	at org.junit.platform.console.shadow.picocli.CommandLine.execute(CommandLine.java:2170)
    	at org.junit.platform.console.options.MainCommand.runCommand(MainCommand.java:137)
    	at org.junit.platform.console.options.MainCommand.run(MainCommand.java:125)
    	at org.junit.platform.console.options.CommandFacade.run(CommandFacade.java:36)
    	at org.junit.platform.console.ConsoleLauncher.run(ConsoleLauncher.java:57)
    	at org.junit.platform.console.ConsoleLauncherTests.displayBanner(ConsoleLauncherTests.java:47)
    	...

@sormuras
Copy link
Member Author

NPE was fixed by bc862e0 and following commit(s).

@sormuras sormuras merged commit 548fb69 into main Aug 28, 2023
13 checks passed
@sormuras sormuras deleted the issues/3419-java-22-picocli branch August 28, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone console tests fails in JDK 22-ea
2 participants