fix #944: provide the resolved parameters in the ExtensionContext #3929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As (almost) suggested in #944, I've added a method
ExtensionContext#getResolvedParameters
(andgetRequiredResolvedParameters
) and an interfaceResolvedParameters
. TheAbstractExtensionContext
can store and return those. TheParameterResolutionUtils
store them, but I had to introduce another but internal interfaceResolvedParametersStore
to make this possible without hurting the visibility scopes betweendescriptor
andexecution
.The problem I ran into is that
TestMethodTestDescriptor#execute
calls the parameter resolvers after allBeforeEach
callbacks and methods. So they can't see them, but that was the purpose of it all.I'm not sure, if this ordering could be inverted: first the parameter resolvers, then the
BeforeEach
handling.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations