-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order test descriptor children in place #4289
Merged
marcphilipp
merged 25 commits into
junit-team:main
from
mpkorstanje:add-test-descriptor-order-children
Feb 5, 2025
Merged
Order test descriptor children in place #4289
marcphilipp
merged 25 commits into
junit-team:main
from
mpkorstanje:add-test-descriptor-order-children
Feb 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is not possible to order children without first removing all children and then adding them back in order. E.g: ```java var children = new ArrayList<>(testDescriptor.getChildren()); Collections.shuffle(children); children.forEach(testDescriptor::removeChild); children.forEach(testDescriptor::addChild); ``` By adding `orderChildren(UnaryOperator<List<TestDescriptor>> orderer)` it now becomes possible to write: ```java testDescriptor.orderChildren(children -> { Collections.shuffle(children); return children; }); ```
mpkorstanje
commented
Jan 30, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
jbduncan
reviewed
Jan 30, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
marcphilipp
requested changes
Jan 31, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
mpkorstanje
force-pushed
the
add-test-descriptor-order-children
branch
from
January 31, 2025 13:08
9b8c821
to
45bb7c8
Compare
marcphilipp
approved these changes
Feb 3, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/descriptor/AbstractTestDescriptor.java
Show resolved
Hide resolved
marcphilipp
requested changes
Feb 3, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
mpkorstanje
commented
Feb 3, 2025
...jupiter-engine/src/main/java/org/junit/jupiter/engine/discovery/AbstractOrderingVisitor.java
Outdated
Show resolved
Hide resolved
mpkorstanje
commented
Feb 3, 2025
.../src/test/java/org/junit/platform/engine/support/descriptor/AbstractTestDescriptorTests.java
Outdated
Show resolved
Hide resolved
mpkorstanje
commented
Feb 3, 2025
junit-platform-engine/src/main/java/org/junit/platform/engine/TestDescriptor.java
Outdated
Show resolved
Hide resolved
mpkorstanje
commented
Feb 3, 2025
...jupiter-engine/src/main/java/org/junit/jupiter/engine/discovery/AbstractOrderingVisitor.java
Outdated
Show resolved
Hide resolved
mpkorstanje
commented
Feb 3, 2025
...jupiter-engine/src/main/java/org/junit/jupiter/engine/discovery/AbstractOrderingVisitor.java
Show resolved
Hide resolved
mpkorstanje
commented
Feb 3, 2025
...ngine/src/main/java/org/junit/platform/engine/support/descriptor/AbstractTestDescriptor.java
Show resolved
Hide resolved
marcphilipp
approved these changes
Feb 4, 2025
marcphilipp
changed the title
Order test descriptors children in place
Order test descriptor children in place
Feb 4, 2025
mpkorstanje
commented
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mpkorstanje Thank you! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, it is not possible to order children
without first removing all children and then
adding them back in order. E.g:
By adding
orderChildren(UnaryOperator<List<TestDescriptor>> orderer)
it now becomes possible to write:Fixes: #4290
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations