Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds request id #63

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: adds request id #63

wants to merge 13 commits into from

Conversation

abxsantos
Copy link
Member

@abxsantos abxsantos commented Jan 21, 2025 •
edited
Loading

Infos

Task name on sprint board

Working implementation example
Django view
image
Publisher
image
Consumer
image

What is being delivered?

  • Sets a custom correlation-id header into django request id local_threading, thus conforming with other entrerprise applications

What impacts?

  • Adds a new project dependency
  • Adds a custom header (that can be overridden) during the published entry creation
  • Sets the correlation-id header (or in case it doesn't exist a random uuid4) into django-request-id local_threading, thus allowing this library to conform with other enterprise applications

Reversal plan

  • Revert commits, redeploy the application via Azure DevOps

Where to monitor

  • The header section in created published entries in Django admin
  • A new field (request_id) will be added in logging, thus allowing this library to conform with other enterprise applications

@abxsantos abxsantos added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 21, 2025
@abxsantos abxsantos self-assigned this Jan 21, 2025
rafaelpadovezi
rafaelpadovezi previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@rafaelpadovezi rafaelpadovezi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

django_outbox_pattern/headers.py Outdated Show resolved Hide resolved
@rafaelpadovezi rafaelpadovezi self-requested a review January 22, 2025 11:21
@abxsantos abxsantos marked this pull request as ready for review January 22, 2025 12:33
@abxsantos abxsantos requested a review from a team as a code owner January 22, 2025 12:33
ricardochaves
ricardochaves previously approved these changes Jan 22, 2025
View reviewed changes
anacarolinacm
anacarolinacm previously approved these changes Jan 22, 2025
View reviewed changes
eduard0m0ya
eduard0m0ya previously approved these changes Jan 22, 2025
View reviewed changes
@abxsantos abxsantos closed this Jan 27, 2025
@abxsantos abxsantos reopened this Jan 27, 2025
ricardochaves
ricardochaves previously approved these changes Jan 29, 2025
View reviewed changes
anacarolinacm
anacarolinacm previously approved these changes Jan 30, 2025
View reviewed changes
fabiohk
fabiohk reviewed Jan 31, 2025
View reviewed changes
django_outbox_pattern/consumers.py Show resolved Hide resolved
django_outbox_pattern/consumers.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niltonfrederico niltonfrederico niltonfrederico approved these changes

@fabiohk fabiohk fabiohk approved these changes

@MatheusGeiger MatheusGeiger MatheusGeiger approved these changes

@phmonte phmonte Awaiting requested review from phmonte

@rafaelpadovezi rafaelpadovezi Awaiting requested review from rafaelpadovezi

@victorhos victorhos Awaiting requested review from victorhos

@VictorOliveiraPy VictorOliveiraPy Awaiting requested review from VictorOliveiraPy

@willianantunes willianantunes Awaiting requested review from willianantunes

@eduard0m0ya eduard0m0ya Awaiting requested review from eduard0m0ya

@ricardochaves ricardochaves Awaiting requested review from ricardochaves

@anacarolinacm anacarolinacm Awaiting requested review from anacarolinacm

Assignees

@abxsantos abxsantos

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@abxsantos @ricardochaves @rafaelpadovezi @willianantunes @niltonfrederico @fabiohk @MatheusGeiger @eduard0m0ya @anacarolinacm