Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade debug from 4.3.3 to 4.3.4 #135

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Apr 7, 2022

Snyk has created this PR to upgrade debug from 4.3.3 to 4.3.4.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.
  • The recommended version was released 21 days ago, on 2022-03-17.
Release notes
Package name: debug
  • 4.3.4 - 2022-03-17

    What's Changed

    New Contributors

    Full Changelog: 4.3.3...4.3.4

  • 4.3.3 - 2021-11-27

    Patch Release 4.3.3

    This is a documentation-only release. Further, the repository was transferred. Please see notes below.

    Thank you to @ taylor1791 and @ kristofkalocsai for their contributions.


    Repository Migration Information

    I've formatted this as a FAQ, please feel free to open an issue for any additional question and I'll add the response here.

    Q: What impact will this have on me?

    In most cases, you shouldn't notice any change.

    The only exception I can think of is if you pull code directly from https://github.com/visionmedia/debug, e.g. via a "debug": "visionmedia/debug"-type version entry in your package.json - in which case, you should still be fine due to the automatic redirection Github sets up, but you should also update any references as soon as possible.

    Q: What are the security implications of this change?

    If you pull code directly from the old URL, you should update the URL to https://github.com/debug-js/debug as soon as possible. The old organization has many approved owners and thus a new repository could (in theory) be created at the old URL, circumventing Github's automatic redirect that is in place now and serving malicious code. I (@ Qix-) also wouldn't have access to that repository, so while I don't think it would happen, it's still something to consider.

    Even in such a case, however, the officially released package on npm (debug) would not be affected. That package is still very much under control (even more than it used to be).

    Q: What should I do if I encounter an issue related to the migration?

    Search the issues first to see if someone has already reported it, and then open a new issue if someone has not.

    Q: Why was this done as a 'patch' release? Isn't this breaking?

    No, it shouldn't be breaking. The package on npm shouldn't be affected (aside from this patch release) and any references to the old repository should automatically redirect.

    Thus, according to all of the "APIs" (loosely put) involved, nothing should have broken.

    I understand there are a lot of edge cases so please open issues as needed so I can assist in any way necessary.

    Q: Why was the repository transferred?

    I'll just list them off in no particular order.

    • The old organization was defunct and abandoned.
    • I was not an owner of the old organization and thus could not ban the non-trivial amount of spam users or the few truly abusive users from the org. This hindered my ability to properly maintain this package.
    • The debug ecosystem intends to grow beyond a single package, and since new packages could not be created in the old org (nor did it make sense for them to live there), a new org made the most sense - especially from a security point of view.
    • The old org has way, way too many approved members with push access, for which there was nothing I could do. This presented a pretty sizable security risk given that many packages in recent years have fallen victim to backdoors and the like due to lax security access.

    Q: Was this approved?

    Yes.[archive]

    Q: Do I need to worry about another migration sometime in the future?

    No.

from debug GitHub release notes
Commit messages
Package name: debug
  • da66c86 4.3.4
  • 9b33412 replace deprecated String.prototype.substr() (#876)
  • c0805cc add section about configuring JS console to show debug messages (#866)

Compare


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@snyk-bot snyk-bot requested a review from jupe as a code owner April 7, 2022 17:01
@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 298ac510-f56d-42db-89a9-e17962b63c10

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.562%

Totals Coverage Status
Change from base Build 79e30261-cb49-4e83-a906-8437f2f2de90: 0.0%
Covered Lines: 258
Relevant Lines: 494

💛 - Coveralls

@jupe jupe merged commit 7b65132 into master Apr 14, 2022
@jupe jupe deleted the snyk-upgrade-ea1aef702c35bbc73a12e28ae6a99918 branch April 14, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants