Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ Add url param to sandbox #15

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Mar 22, 2024

This PR adds an url parameter to the sandbox, enabling people to preview MyST documents online.

I'd like to explicitly reference that somewhere, but I'm not sure whether we want to add description text to the sandbox page. I could modify the demo text, as an explainer?

Closes #4

Copy link

welcome bot commented Mar 22, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@agoose77 agoose77 requested a review from rowanc1 March 22, 2024 11:57
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice will give this a go with the other PR and get it out!

@rowanc1 rowanc1 force-pushed the agoose77/feat-add-url-param branch from 7381bcb to 04c1780 Compare March 22, 2024 13:43
@rowanc1
Copy link
Member

rowanc1 commented Mar 22, 2024

Works great!

image

@rowanc1
Copy link
Member

rowanc1 commented Mar 22, 2024

Will leave it to another PR to add docs

@rowanc1 rowanc1 merged commit 21987a9 into main Mar 22, 2024
@rowanc1 rowanc1 deleted the agoose77/feat-add-url-param branch March 22, 2024 13:46
Copy link

welcome bot commented Mar 22, 2024

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Load URL" feature to "Try MyST"
2 participants