🎆 Prevent html outputs that translate to empty images (#1739)

jupyter-book · Jan 9, 2025 · 93af5a1 · 93af5a1
1 parent ea19e66
commit 93af5a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/large-countries-cheer.md b/.changeset/large-countries-cheer.md
@@ -0,0 +1,5 @@
+---
+'myst-cli': patch
+---
+
+Prevent html outputs that translate to empty images
diff --git a/packages/myst-cli/src/transforms/outputs.ts b/packages/myst-cli/src/transforms/outputs.ts
@@ -279,6 +279,9 @@ export function reduceOutputs(
             ],
           };
           htmlTransform(htmlTree);
+          if ((selectAll('image', htmlTree) as GenericNode[]).find((htmlImage) => !htmlImage.url)) {
+            return undefined;
+          }
           return htmlTree.children;
         } else if (content_type.startsWith('image/')) {
           const path = writeCachedOutputToFile(session, hash, cache.$outputs[hash], writeFolder, {